Enhance block by root log #13472
Merged
Enhance block by root log #13472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
enhance-request-block-by-root-log
branch
2 times, most recently
from
a2db288 to
0f37570
Compare
terencechain
force-pushed
the
enhance-request-block-by-root-log
branch
from
0f37570 to
af0d9a3
Compare
prestonvanloon
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a block's parent or attestation head vote is not in the database, the beacon node logs a request message for it. This message can be either "Requesting block for pending attestation" or "Requesting parent block"'. However, these logs are misleading because they are generated before the requested root is filtered by
s.seenPendingBlocks[r] || s.cfg.chain.BlockBeingSynced(r). It would be more accurate to log these messages after applying the filter. Although logging later in the function means losing information likeattSlot,attCount, orslot, these details are likely irrelevant for a debug log, and changing the debug log format should not be a concern...