Fix KZG commitment inclusion proof tag in blob sidecar JSON RPC response #13475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prestonvanloon
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Renames the blob sidecar field containing the inclusion proof from
commitment_inclusion_prooftokzg_commitment_inclusion_proof, which is the field name in the beacon API specification.Hive was complaining and failing all tests when it came to verifying the blob sidecars from the beacon node, but I've tested with this change and test are not failing anymore due to this issue.
Which issues(s) does this PR fix?
No issue number for this afaik.
Other notes for review
There are other uses of
commitment_inclusion_proofbut I did not want to touch anything else that was unnecessary.