Return payload value in Wei from /eth/v3/validator/blocks
#13497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
rkapka
force-pushed
the
produce-block-wei
branch
from
5d939cd to
071a1a1
Compare
rkapka
commented
Jan 22, 2024
james-prysm
reviewed
Jan 22, 2024
james-prysm
reviewed
Jan 22, 2024
james-prysm
reviewed
Jan 22, 2024
james-prysm
reviewed
Jan 22, 2024
| @@ -435,6 +435,9 @@ func (s *Service) validateMergeTransitionBlock(ctx context.Context, stateVersion | |||
| if err != nil { | |||
| return invalidBlock{error: err} | |||
| } | |||
| if payload == nil { | |||
There was a problem hiding this comment.
I'm not sure if this should exist... doesn't the check below is empty execution data deal with this?
There was a problem hiding this comment.
you are right, I moved this check to IsEmptyExecutionData
| value uint64 | ||
| p *enginev1.ExecutionPayloadCapella | ||
| weiValue math.Wei | ||
| gweiValue uint64 |
There was a problem hiding this comment.
do we still need to keep gweiValue now we have weiValue?
There was a problem hiding this comment.
I kept gweiValue so that we don't have to convert every time we want to get the value in Gwei.
james-prysm
approved these changes
Jan 24, 2024
terencechain
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
consensus-types/blocks/getters.gowhere callingExecution()would return a new wrapped object with0value. Actually there is no need to unwrap and re-wrap, we can just return the field value directly. Making sure it's of the correct type should be done in the setter.ValueInWei()method to theExecutionDatainterface so that we can retrieve the payload value both in Wei and Gwei. The/eth/v3/validator/blocksAPI endpoint should return Wei values.Which issues(s) does this PR fix?
Fixes #13466
Aligns with ethereum/beacon-APIs#400
Other notes for review