add BlockBatchLimit comment: Maximum 128 #13502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
james-prysm
reviewed
Jan 24, 2024
| @@ -158,7 +158,7 @@ var ( | |||
| // BlockBatchLimit specifies the requested block batch size. | |||
| BlockBatchLimit = &cli.IntFlag{ | |||
| Name: "block-batch-limit", | |||
| Usage: "The amount of blocks the local peer is bounded to request and respond to in a batch.", | |||
| Usage: "The amount of blocks the local peer is bounded to request and respond to in a batch. Maximum 128", | |||
There was a problem hiding this comment.
This number changes depending on network so just saying maximum 128 might not be great, we should think of a better way to word this
There was a problem hiding this comment.
got it. It seems that it's not so good to word this here because the range is dynamic.
What about adding param judgement on the fetchBlocksFromPeer to make user can realize it without enable the Debug otherwise user would keep waiting here because there is no any error msg . like this :
maxRequest := params.MaxRequestBlock(slots.ToEpoch(start))
if count > maxRequest {
log.WithField("count", count).WithField("maxRequest", maxRequest).Error("Requested count is too high, reducing")
}
prestonvanloon
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Documentation
What does this PR do? Why is it needed?
As mentioned in the issue, make people aware that there is a range limit of BlockBatchLimit. Especially since it was changed on the Dencun.
Which issues(s) does this PR fix?
Fixes #13499
Other notes for review