Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement beacon committee selections #13503

Merged
merged 26 commits into from
Feb 5, 2024

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jan 23, 2024

What type of PR is this?
Feature

What does this PR do? Why is it needed?
This PR introduces --distributed flag to add support for usage of prysm validator in a distributed validator cluster. This PR also adds support for beacon_committee_selections which is needed to support attestation aggregation duties in a distributed validator cluster.

Which issues(s) does this PR fix?

Fixes #11985

@dB2510 dB2510 requested a review from a team as a code owner January 23, 2024 11:45
@dB2510 dB2510 force-pushed the beacon-committee-selections branch from cb6201b to 7801ae5 Compare January 23, 2024 12:05
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the endpoint in the Beacon API and return a 501 response as indicated in the spec

beacon-chain/rpc/eth/shared/structs.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/shared/structs.go Outdated Show resolved Hide resolved
cmd/validator/flags/flags.go Show resolved Hide resolved
validator/client/beacon-api/beacon_committee_selections.go Outdated Show resolved Hide resolved
validator/client/beacon-api/beacon_committee_selections.go Outdated Show resolved Hide resolved
validator/client/beacon-api/beacon_committee_selections.go Outdated Show resolved Hide resolved
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change back validators request to POST

rkapka
rkapka previously approved these changes Feb 2, 2024
@rkapka rkapka enabled auto-merge February 2, 2024 17:08
auto-merge was automatically disabled February 2, 2024 18:14

Head branch was pushed to by a user without write access

@rkapka rkapka enabled auto-merge February 2, 2024 18:29
rkapka
rkapka previously approved these changes Feb 2, 2024
auto-merge was automatically disabled February 5, 2024 09:27

Head branch was pushed to by a user without write access

@rkapka rkapka enabled auto-merge February 5, 2024 15:43
@rkapka rkapka added this pull request to the merge queue Feb 5, 2024
Merged via the queue into prysmaticlabs:develop with commit 55a29a4 Feb 5, 2024
17 checks passed
@dB2510 dB2510 deleted the beacon-committee-selections branch February 6, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attestation and Sync Committee aggregation selection
2 participants