Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few minor nits in protobuf definitions #13512

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix a few minor nits in protobuf definitions #13512

merged 1 commit into from
Feb 6, 2024

Conversation

jtraglia
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • Add blank lines between fields with comments. This is for consistency with other files.
  • Use blob.size rather than 131072, might as well since it's defined.
  • Replace confusing comment for Blob. I get what it's saying but it's strange.
    • BLS_FIELD_ELEMENT should be BYTES_PER_FIELD_ELEMENT.
    • "multiplies" should have been "multiples of".
    • But even then it doesn't read very well.
  • Comment for commitments should be MAX_BLOB_COMMITMENTS_PER_BLOCK instead of MAX_BLOBS_PER_BLOCK.
  • Fix comment that says SignedBLSToExecutionChange is new to Deneb 😃
  • Add comment describing how blob.size is calculated.

@jtraglia jtraglia requested review from prestonvanloon and a team as code owners January 23, 2024 19:13
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@prestonvanloon prestonvanloon added this pull request to the merge queue Feb 6, 2024
Merged via the queue into prysmaticlabs:develop with commit 01116f7 Feb 6, 2024
17 checks passed
@jtraglia jtraglia deleted the fix-proto-nits branch February 6, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants