Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Validate Beacon Block #13517

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Cleanup Validate Beacon Block #13517

merged 1 commit into from
Jan 24, 2024

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jan 24, 2024

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

In this PR, we cleanup our validateBeaconBlock method and instead group all the different validity conditions by fork. All the phase 0 conditions are grouped into their own method.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added Ready For Review A pull request ready for code review Sync Sync (regular, initial, checkpoint) related issues labels Jan 24, 2024
@nisdas nisdas requested a review from a team as a code owner January 24, 2024 05:31
terencechain
terencechain approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nisdas nisdas enabled auto-merge January 24, 2024 05:46
@nisdas nisdas added this pull request to the merge queue Jan 24, 2024
Merged via the queue into develop with commit a2892b1 Jan 24, 2024
17 checks passed
@nisdas nisdas deleted the cleanupValidateBeaconBlock branch January 24, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review Sync Sync (regular, initial, checkpoint) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisdas @terencechain