Enable Backfill in E2E #13524
Merged
Enable Backfill in E2E #13524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
kasey
reviewed
Jan 25, 2024
| @@ -0,0 +1,38 @@ | |||
| package flags | |||
There was a problem hiding this comment.
What is the reason to break flags out into a separate package?
There was a problem hiding this comment.
We need to import the backfill flag to our feature package, since we want it as part of --dev. If you dont have a separate package, build fails due to dependency cycles
kasey
approved these changes
Jan 26, 2024
| @@ -283,7 +283,7 @@ func (node *BeaconNode) Start(ctx context.Context) error { | |||
| // on our features or the beacon index is a multiplier of 2 (idea is to split nodes | |||
| // equally down the line with one group having feature flags and the other without | |||
| // feature flags; this is to allow A-B testing on new features) | |||
| if !config.TestFeature || index%2 == 0 { | |||
| if !config.TestFeature || index != 1 { | |||
There was a problem hiding this comment.
The comment above indicates this was supposed to be only for multiples of 2 - which one is intended?
There was a problem hiding this comment.
Will fix the comment, but the current intent is to only have 1 node running as a control rather than splitting it down the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
E2E Improvement
What does this PR do? Why is it needed?
This enables backfill for our E2E runs by adding it to our
devmode.Which issues(s) does this PR fix?
N.A
Other notes for review