only update head at 10 seconds when validating #13570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
reviewed
Feb 1, 2024
| @@ -95,7 +95,9 @@ func (s *Service) spawnProcessAttestationsRoutine() { | |||
| return | |||
| case slotInterval := <-ticker.C(): | |||
There was a problem hiding this comment.
This ticker is also triggered at 0s, so either it's a bug or we need to update the PR title and description
There was a problem hiding this comment.
Nvm. I see the if slotInterval.Interval > 0 { below
terencechain
previously approved these changes
Feb 1, 2024
terencechain
approved these changes
Feb 2, 2024
prestonvanloon
approved these changes
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not call to update head at 10 seconds if the beacon is not serving validators.