Revise blob sidecar not found log #13571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
changed the title
kasey
reviewed
Feb 1, 2024
| @@ -80,7 +80,7 @@ func (s *Service) blobSidecarByRootRPCHandler(ctx context.Context, msg interface | |||
| sc, err := s.cfg.blobStorage.Get(root, idx) | |||
| if err != nil { | |||
| if db.IsNotFound(err) { | |||
| log.WithError(err).Debugf("BlobSidecar not found in db, root=%x, index=%d", root, idx) | |||
| log.WithError(err).Debugf("Serving blob sidecar request, not found in db, root=%x, index=%d", root, idx) | |||
There was a problem hiding this comment.
If the goal is to make it clear that this is untrusted input, we could make that a little more clear like "Peer requested blob sidecar by root which was not found in db".
terencechain
force-pushed
the
update-blobsidecar-not-found-log
branch
from
92466e6 to
426e2df
Compare
prestonvanloon
previously approved these changes
Feb 1, 2024
| @@ -80,7 +80,7 @@ func (s *Service) blobSidecarByRootRPCHandler(ctx context.Context, msg interface | |||
| sc, err := s.cfg.blobStorage.Get(root, idx) | |||
| if err != nil { | |||
| if db.IsNotFound(err) { | |||
| log.WithError(err).Debugf("BlobSidecar not found in db, root=%x, index=%d", root, idx) | |||
| log.WithError(err).Debugf("Peer requested blob sidecar by root which was not found in db, root=%x, index=%d", root, idx) | |||
There was a problem hiding this comment.
Suggestion: This would be better to remove the templating and use fields. Easier to collect and measure this log
prestonvanloon
approved these changes
Feb 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised log messaging to clarify scenarios where a node, despite having the blob sidecar locally, encounters an error serving it to a peer due to the sidecar not being found in the database