Get the right head state when proposing a failed reorg #13579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
reviewed
Feb 2, 2024
nisdas
previously approved these changes
Feb 3, 2024
nisdas
reviewed
Feb 5, 2024
| head, err := vs.HeadFetcher.HeadState(ctx) | ||
| // process attestations and update head in forkchoice | ||
| vs.ForkchoiceFetcher.UpdateHead(ctx, vs.TimeFetcher.CurrentSlot()) | ||
| headRoot := vs.ForkchoiceFetcher.CachedHeadRoot() |
There was a problem hiding this comment.
why not just derive the parent and head root in getParentHeadState and do all the checks in there ? You wouldn't need to call this in the main GetBeaconBlock method.
There was a problem hiding this comment.
it's harder to test, but I can split it up in yet an extra layer.
nisdas
previously approved these changes
Feb 5, 2024
nisdas
reviewed
Feb 5, 2024
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if head.Slot() >= slot { |
There was a problem hiding this comment.
this would be a failure condition, no ? You wouldn't be able to process the block if the head slot is more than our wanted slot
nisdas
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following bug:
The node is about to propose block N+1. It syncs block N, based on N-1, and is late, the node head remains being N-1 and will attempt a reorg. If at the beginning of the slot N+1 the node N has shown to be strong, the node relents and starts building a local payload immediately on top of N.
The node obtains the blockroot of N from forkchoice and requests the corresponding state advanced to N+1.
If the node also has a cache miss (in the NSC) then the node will advance the head state to N+1. Here's the bug since this would produce the state based from N-1, instead of N as we want.
cc @nisdas