Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blob batch verifier pointer receiver #13649

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix blob batch verifier pointer receiver #13649

merged 1 commit into from
Feb 21, 2024

Conversation

terencechain
Copy link
Member

blobBatchVerifier should be a pointer receiver for VerifiedROBlobs like newVerifier. The value is 2 pointers so this is just an aesthetic issue that shows up as a warning in people's IDE

@terencechain terencechain added the Ready For Review A pull request ready for code review label Feb 21, 2024
@terencechain terencechain requested a review from a team as a code owner February 21, 2024 19:59
@terencechain terencechain added this pull request to the merge queue Feb 21, 2024
Merged via the queue into develop with commit 9f67ad9 Feb 21, 2024
17 checks passed
@terencechain terencechain deleted the fix-batch-verifier-ptr-receiver branch February 21, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saolyn saolyn saolyn approved these changes

@kasey kasey kasey approved these changes

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terencechain @kasey @saolyn