call fsync between part file write and rename #13652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beacon-chain/db/filesystem/blob.go
Outdated
| @@ -155,6 +155,9 @@ func (bs *BlobStorage) Save(sidecar blocks.VerifiedROBlob) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if err := partialFile.Sync(); err != nil { | |||
There was a problem hiding this comment.
This file is closed already?
There was a problem hiding this comment.
no you're right, fixed.
kasey
force-pushed
the
fsync-blob-writes
branch
from
43bbe7b to
0f907da
Compare
prestonvanloon
previously approved these changes
Feb 23, 2024
kasey
force-pushed
the
fsync-blob-writes
branch
from
0f907da to
6029ac0
Compare
kasey
force-pushed
the
fsync-blob-writes
branch
from
6029ac0 to
c0b5302
Compare
terencechain
approved these changes
Feb 23, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
Mar 1, 2024
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com> (cherry picked from commit 70e1b11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds a feature flag
--blob-save-fsync. When this flag is set, the blob storage code will call fsync after writing blob data to the.partfile, before renaming the part file to the.sszfile.This can be used by node operators who want extra reassurance that zero-length blob files won't be written, particularly in the event of a node restart.