Copy Validator Field Trie #13661
Merged
Copy Validator Field Trie #13661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
approved these changes
Feb 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimization
What does this PR do? Why is it needed?
In #10884, we introduced the ability to simply transfer a trie rather than constantly copy it to save the amount of memory allocated by the node. However with the beacon chain growing in size and the reality with dealing with late blocks during changes to the validator registry, this approach has many downsides.
We now choose to bring back the ability to copy the validator trie during recomputation. The downside is a slight increase in memory used by the node. However, having the trie copied allows the node to deal with late blocks much more efficiently mainly due to the fact that validator roots do not have to be recomputed from scratch. This step is very expensive and can stress the node non-trivially.
Which issues(s) does this PR fix?
N.A
Other notes for review