Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed reorg log #13679

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix failed reorg log #13679

merged 1 commit into from
Feb 29, 2024

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Feb 28, 2024

h/a to Antithesis for reporting this.

We treat succesful reorgs as failed ones and log them incorrectly. This PR fixes this.

@potuz potuz added the Bug Something isn't working label Feb 28, 2024
@potuz potuz requested a review from a team as a code owner February 28, 2024 20:25
@potuz potuz enabled auto-merge February 28, 2024 20:26
@potuz potuz added this pull request to the merge queue Feb 29, 2024
Merged via the queue into develop with commit 2e2ef4a Feb 29, 2024
17 checks passed
@potuz potuz deleted the fix_failed_reorg_log branch February 29, 2024 16:06
nalepae pushed a commit that referenced this pull request Feb 29, 2024
prestonvanloon pushed a commit that referenced this pull request Mar 1, 2024
(cherry picked from commit 2e2ef4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants