exit blob fetching for cp block if outside retention #13686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Mar 5, 2024
kasey
added a commit
that referenced
this pull request
Mar 5, 2024
* exit blob fetching for cp block if outside retention * regression test --------- Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com> (cherry picked from commit b3caaa9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
If the checkpoint sync origin is outside the blob retention epoch, we will have pruned its blobs. This creates a false positive where we think we need to fetch the blobs, but since they are outside the retention period, we may not be able to get them from peers.
This PR exits the checkpoint block blob fetching routine if the checkpoint block slot is outside the retention period.