Use justified checkpoint from head state to build attestation #13703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Blocked
terencechain
force-pushed
the
head-state-jcp-att
branch
from
d93b452 to
e7b9e3d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
nisdas
previously approved these changes
Mar 8, 2024
| @@ -401,7 +401,19 @@ func (s *Service) GetAttestationData( | |||
| if err != nil { | |||
| return nil, &RpcError{Reason: Internal, Err: errors.Wrap(err, "could not get target root")} | |||
| } | |||
| justifiedCheckpoint := s.FinalizedFetcher.CurrentJustifiedCheckpt() | |||
|
|
|||
| headState, err := s.HeadFetcher.HeadState(ctx) | |||
There was a problem hiding this comment.
you should fetch the read only version of the head state otherwise this will do a copy and blow up the memory of nodes running with many keys.
There was a problem hiding this comment.
It's just one copy per slot because of the cache. But I'll change it to read-only because that's always better
| if err != nil { | ||
| return nil, &RpcError{Reason: Internal, Err: errors.Wrap(err, "could not get head state")} | ||
| } | ||
| if coreTime.CurrentEpoch(headState) < slots.ToEpoch(req.Slot) { // Ensure justified checkpoint safety by processing head state across the boundary. |
There was a problem hiding this comment.
why advance though ? Previously we did not advance either
There was a problem hiding this comment.
We did advance before. See #13300
terencechain
force-pushed
the
head-state-jcp-att
branch
from
e7b9e3d to
c886aaf
Compare
potuz
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the justified checkpoint for attestation is derived from the fork choice store. To ensure maximal safety, the justified checkpoint for attestation should be derived from the head state and process slots across epoch boundaries when necessary.