Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kzg): Additional tests for KZG commitments #13758

Merged
merged 4 commits into from
Mar 19, 2024
Merged

chore(kzg): Additional tests for KZG commitments #13758

merged 4 commits into from
Mar 19, 2024

Conversation

letonchanh
Copy link
Contributor

@letonchanh letonchanh commented Mar 17, 2024 •
edited
Loading

What type of PR is this?

Other: Add some tests for the KZG commitments.

What does this PR do? Why is it needed?

This PR adds two more tests for the KZG commitments to

  • Test the logic of topProof inside MerkleProofKZGCommitment.
  • Explain and test the calculation of the Merkle index of the KZG commitments root in the Body's Merkle tree, which is used in KZGOffset.

Which issues(s) does this PR fix?

No issues were fixed.

Other notes for review

@letonchanh letonchanh requested a review from a team as a code owner March 17, 2024 15:42
nisdas
nisdas approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this !

@nisdas nisdas added this pull request to the merge queue Mar 19, 2024
Merged via the queue into prysmaticlabs:develop with commit d779e65 Mar 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisdas nisdas nisdas approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@letonchanh @nisdas