Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default fee recipient if tracked val fails #13768

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Set default fee recipient if tracked val fails #13768

merged 1 commit into from
Mar 18, 2024

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Mar 18, 2024

When proposing a block, if the validator is not in the tracked validators cache, set it's fee recipient from the beacon node.

@potuz potuz requested a review from a team as a code owner March 18, 2024 18:59
@james-prysm james-prysm self-requested a review March 18, 2024 19:00
james-prysm
james-prysm approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any questions were explained on slack, we are avoiding using wrongly tracked values here. Note that a validator index at 0 with an intensional burn address will still be overwritten by the default.

@potuz potuz enabled auto-merge March 18, 2024 19:22
@potuz potuz added this pull request to the merge queue Mar 18, 2024
Merged via the queue into develop with commit 2dd4834 Mar 18, 2024
16 of 17 checks passed
@potuz potuz deleted the set_default_fee_recipient_proposing branch March 18, 2024 19:42
@nalepae
Copy link
Contributor

nalepae commented Mar 18, 2024 •
edited
Loading

Note that a validator index at 0 with an intensional burn address will still be overwritten by the default.

Even if this is a very unlikely case, this is still possible and IMO should be considered as a bug.
==> @potuz @prestonvanloon @james-prysm are you OK if I open an issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-prysm james-prysm james-prysm approved these changes

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@potuz @nalepae @prestonvanloon @james-prysm