add log message if in da check at slot end #13776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
Mar 20, 2024
| @@ -558,6 +559,17 @@ func (s *Service) isDataAvailable(ctx context.Context, root [32]byte, signed int | |||
| // The gossip handler for blobs writes the index of each verified blob referencing the given | |||
| // root to the channel returned by blobNotifiers.forRoot. | |||
| nc := s.blobNotifiers.forRoot(root) | |||
| nextSlot := slots.BeginsAt(signed.Block().Slot()+1, s.genesisTime) | |||
| // Avoid underflow if Now is somehow after the next slot start. | |||
There was a problem hiding this comment.
I think instead of an error it's fine to simply not log these cases:
- On init sync it won't be noisy.
- For very late blocks anyway the logs already show all logs out of order, so the context deadline error we already have is good enough.
There was a problem hiding this comment.
init-sync won't go into this path so no issue there, but I can remove the else error log you mention since we'll see the deadline anyway.
potuz
reviewed
Mar 20, 2024
| if nextSlot.After(time.Now()) { | ||
| nextSlotDur = time.Until(nextSlot) | ||
| } | ||
| slotEnd := time.NewTimer(nextSlotDur) |
There was a problem hiding this comment.
I think this may cause a timer that expires very quickly still, the guarantee that time.NewTimer() gives is that it has a minimum wait time.
I'd rather simply not log this at all if the block is coming after the slot's end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This changes the DA check so that it will log if the check is running at the end of the slot for the given block, which provides helpful debugging information for blocks with late blobs.