fix handling of goodbye messages for limited peers #13785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
approved these changes
Mar 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
I've noticed these rate limit errors on the goodbye topic:
[2024-03-20 18:11:17] DEBUG sync: Could not handle p2p RPC (ptr) error=rate limited peer=16Uiu2HAm34cymQmtLYvFQJd5jzW1fYE4xcUPyW4LRmBxGhLfsR4U topic=/eth2/beacon_chain/req/goodbye/1/ssz_snappyI'm assuming what's happening here is that we rate limit a peer, and they choose to disconnect with us as a result, at which point they can send us a (optional) goodbye message, and we then raise this error saying "you can't call my goodbye rpc, you are rate limited". The problem is this prevents us from correctly handling the disconnect as implemented in the goodbye rpc handler. Since we're about to disconnect the peer with a reconnect backoff anyway, we should allow this to proceed and just log the faintly interesting fact that the peer is already rate limited.