use time.NewTimer()
to avoid possible memory leaks
#13800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Using
time.After()
in a loop may cause possible memory leaks. As Golang code comment says,Timer
is not recovered until fires. In a loop, too many timers may be created and are not garbage collected.So this PR is fixing possible memory leaks by using
time.NewTimer()
andReset()
Which issues(s) does this PR fix?
Fixes #
Other notes for review