Remove check for duplicates in pending attestation queue #13814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current queue will only save 1 unaggregated attestation for a pending block because we wrap the object into a SignedAggregatedAttestationAndProof with a zeroed aggregator.
potuz
force-pushed
the
remove_duplicate_check_pending_att
branch
from
1c19a01 to
662d937
Compare
Comment on lines
+183
to
+184
| // Skip if the attestation from the same aggregator already exists in | ||
| // the pending queue. |
There was a problem hiding this comment.
We should fix this comment right?
There was a problem hiding this comment.
Actually I think it's fine. The idea didn't change
terencechain
previously approved these changes
Mar 27, 2024
terencechain
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current queue will only save 1 unaggregated attestation for a pending block because we wrap the object into a SignedAggregatedAttestationAndProof with a zeroed aggregator. Since the unique callers of this queue already make sure that the objects are not duplicated in the gossip pipeline, we can safely remove the check
This is a bug present since genesis.