Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EnableEIP4881 flag #13826

Merged
merged 19 commits into from
Apr 24, 2024
Merged

Remove EnableEIP4881 flag #13826

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7667eee
Remove EnableEIP4881 flag
saolyn Mar 28, 2024
1fe248e
Gaz
saolyn Mar 28, 2024
8c14ee5
Fix missing error handler
saolyn Mar 28, 2024
5f8ae09
Merge branch 'develop' into cleanup-eip4881
saolyn Apr 3, 2024
e9a9241
Remove old tree and fix tests
saolyn Apr 3, 2024
ac35abe
Gaz
saolyn Apr 3, 2024
620ed8b
Fix build import
saolyn Apr 3, 2024
9de364d
Replace depositcache
saolyn Apr 3, 2024
678652d
Add pendingDeposit tests
saolyn Apr 3, 2024
8c1caef
Nishant's fix
saolyn Apr 18, 2024
d16d0f9
Fix unsafe uint64 to int
saolyn Apr 18, 2024
a424a0c
Fix other unsafe uint64 to int
saolyn Apr 18, 2024
3843fea
Merge branch 'develop' into cleanup-eip4881
saolyn Apr 18, 2024
8bc6be6
Remove: RemovePendingDeposit
saolyn Apr 19, 2024
21e5781
Deprecate and remove DisableEIP4881 flag
saolyn Apr 19, 2024
9f6930a
Check: index not greater than deposit count
saolyn Apr 19, 2024
5b39511
Merge branch 'develop' into cleanup-eip4881
saolyn Apr 19, 2024
3244e9f
Merge branch 'develop' into cleanup-eip4881
saolyn Apr 23, 2024
661882b
Move index check
saolyn Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beacon-chain/cache/depositsnapshot/deposit_tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func (d *DepositTree) getProof(index uint64) ([32]byte, [][32]byte, error) {
if err != nil {
return [32]byte{}, nil, err
}
if finalizedDeposits > 0 && i <= finalizedIdx {
if finalizedDeposits > 0 && i <= finalizedIdx || index >= d.depositCount {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do the index check at the very beginning ? Just after we check the deposit count

return [32]byte{}, nil, ErrInvalidIndex
}
leaf, proof := generateProof(d.tree, index, DepositContractDepth)
Expand Down
Loading