Initsync skip local blobs #13827
Merged
Initsync skip local blobs #13827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
force-pushed
the
initsync-skip-local-blobs
branch
from
9fa1151 to
2e7b7e2
Compare
kasey
force-pushed
the
initsync-skip-local-blobs
branch
from
f76e31c to
5afcca0
Compare
beacon-chain/das/availability.go
Outdated
Comment on lines
98
to
101
| if err == nil { | ||
| entry.setDiskSummary(sumz.Summary(root)) | ||
| } | ||
|
|
There was a problem hiding this comment.
Please do something about err != nil
There was a problem hiding this comment.
The summarizer is an optional optimization. If for whatever reason the summarizer didn't successfully init, we just don't use it. But a debug log would make sense.
Comment on lines
429
to
436
| for z := len(fc) - 1; z > i; z-- { | ||
| hcz := fc[z] | ||
| if bs.Summary(hcz.root).AllAvailable(hcz.count) { | ||
| continue | ||
| } | ||
| needed.high = hcz.slot | ||
| return needed | ||
| } |
There was a problem hiding this comment.
Does this assume that fc is a sorted list? If so, is that a safe assumption?
There was a problem hiding this comment.
It's a requirement per specs: https://github.com/prysmaticlabs/prysm/blob/develop/beacon-chain/sync/rpc_send_request.go#L93-L103
prestonvanloon
approved these changes
Apr 5, 2024
Merged
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
* wip - init-sync skip available blob req * satisfy deep source * gaz * don't need to sort blobs; simplify blobRequest stack * wip debug log to watch blob skip behavior * unit tests for new blob req generator * refactor to reduce blob req func count * log when WaitForSummarizer fails --------- Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Modify blob request methods to skip slot ranges where we already have blobs on disk. Also modifies the availability store so that if a blob is visible in the pruner cache, it does not require that index to be in the availability store cache, only verifying and savings blobs that are not yet known to the cache.