Use retention period when fetching blobs #13869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
prestonvanloon
approved these changes
Apr 11, 2024
nisdas
reviewed
Apr 12, 2024
| @@ -299,6 +299,11 @@ func (bs *BlobStorage) Clear() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // WithinRetentionPeriod checks if the requested epoch is within the blob retention period. | |||
| func (bs *BlobStorage) WithinRetentionPeriod(requested, current primitives.Epoch) bool { | |||
| return requested+bs.retentionEpochs >= current | |||
There was a problem hiding this comment.
this can overflow if retentionEpochs is a very large value
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Blobs endpoint uses data availability period (which is always equal
MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS) instead of retention period to determine if it should return early with no blobs.Which issues(s) does this PR fix?
Fixes #13853