Add Data Column Gossip Handlers #13894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
kasey,
nalepae and
rkapka
and removed request for
a team
nisdas
added
Ready For Review
nalepae
reviewed
Apr 23, 2024
| @@ -96,6 +96,24 @@ func VerifyBlockHeaderSignature(beaconState state.BeaconState, header *ethpb.Sig | |||
| return signing.VerifyBlockHeaderSigningRoot(header.Header, proposerPubKey, header.Signature, domain) | |||
| } | |||
|
|
|||
| func VerifyBlockHeaderSignatureUsingCurrentFork(beaconState state.BeaconState, header *ethpb.SignedBeaconBlockHeader) error { | |||
nalepae
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nisdas
added a commit
that referenced
this pull request
May 16, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
May 30, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
May 30, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Jun 12, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nisdas
added a commit
that referenced
this pull request
Jul 4, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nisdas
added a commit
that referenced
this pull request
Jul 18, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Jul 29, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nisdas
added a commit
that referenced
this pull request
Aug 14, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nisdas
added a commit
that referenced
this pull request
Aug 15, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nisdas
added a commit
that referenced
this pull request
Aug 20, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Aug 27, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Aug 28, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
nalepae
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Add Data Column Subscriber * Add Data Column Vaidator * Wire all Handlers In * Fix Build * Fix Test * Fix IP in Test * Fix IP in Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds in support for data column gossip validation. It initializes the validation pipelines for data columns and adds in the respective subscriber. This will allow a peerDAS enabled node to subscribe to data columns. The only things left out are the validation of kzg inclusion proofs and kzg proofs which depend on #13877 .
This PR also doesn't handle the column event handling in
blockchain. That will be addressed in a future PRWhich issues(s) does this PR fix?
Fixes #
Other notes for review