Enable E2E For PeerDAS #13945
Merged
Enable E2E For PeerDAS #13945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
terencechain,
rkapka and
james-prysm
and removed request for
a team
nalepae
reviewed
May 7, 2024
nalepae
reviewed
May 7, 2024
nalepae
reviewed
May 7, 2024
beacon-chain/core/peerdas/helpers.go
Outdated
Comment on lines
279
to
288
| for i := 0; i < len(sc.DataColumn); i++ { | ||
| copiedI := uint64(i) | ||
| rowIdx = append(rowIdx, copiedI) | ||
| colI := sc.ColumnIndex * copiedI | ||
| colIdx = append(colIdx, colI) | ||
| } |
There was a problem hiding this comment.
Suggested change
| for i := 0; i < len(sc.DataColumn); i++ { | |
| copiedI := uint64(i) | |
| rowIdx = append(rowIdx, copiedI) | |
| colI := sc.ColumnIndex * copiedI | |
| colIdx = append(colIdx, colI) | |
| } | |
| for i := uint64(0); i < uint64(len(sc.DataColumn)); i++ { | |
| rowIdx = append(rowIdx, i) | |
| colI := sc.ColumnIndex * i | |
| colIdx = append(colIdx, colI) | |
| } |
nalepae
reviewed
May 7, 2024
nalepae
reviewed
May 7, 2024
| @@ -24,5 +26,18 @@ func Start() error { | |||
| if err != nil { | |||
| return errors.Wrap(err, "could not initialize go-kzg context") | |||
| } | |||
| // Length of a G1 point, converted from hex to binary. | |||
| g1s := make([]byte, len(parsedSetup.SetupG1Lagrange)*(len(parsedSetup.SetupG1Lagrange[0])-2)/2) | |||
| for i, g1 := range parsedSetup.SetupG1Lagrange { | |||
There was a problem hiding this comment.
From deepsource:
copy of parsedSetup.SetupG1Lagrange (65536 bytes) can be avoided with &parsedSetup.SetupG1Lagrange
Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nisdas
added a commit
that referenced
this pull request
May 16, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
May 30, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
May 30, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Jun 12, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nisdas
added a commit
that referenced
this pull request
Jul 4, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Jul 17, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Jul 17, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nisdas
added a commit
that referenced
this pull request
Jul 18, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Jul 18, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Jul 29, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nisdas
added a commit
that referenced
this pull request
Aug 14, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nisdas
added a commit
that referenced
this pull request
Aug 15, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nisdas
added a commit
that referenced
this pull request
Aug 20, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Aug 27, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Aug 28, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Aug 28, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Oct 7, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Oct 7, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Oct 8, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Oct 23, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Oct 24, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Nov 20, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Nov 22, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Nov 22, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Nov 25, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Nov 25, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae
added a commit
that referenced
this pull request
Nov 27, 2024
* Enable E2E And Add Fixes * Register Same Topic For Data Columns * Initialize Capacity Of Slice * Fix Initialization of Data Column Receiver * Remove Mix In From Merkle Proof * E2E: Subscribe to all subnets. * Remove Index Check * Remaining Bug Fixes to Get It Working * Change Evaluator to Allow Test to Finish * Fix Build * Add Data Column Verification * Fix LoopVar Bug * Do Not Allocate Memory * Update beacon-chain/blockchain/process_block.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Update beacon-chain/core/peerdas/helpers.go Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * Gofmt * Fix It Again * Fix Test Setup * Fix Build * Fix Trusted Setup panic * Fix Trusted Setup panic * Use New Test --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Testing Addition
What does this PR do? Why is it needed?
This PR enables E2E and also addresses the respective bugs found in our e2e run.
Current Bugs Fixed:
Which issues(s) does this PR fix?
Fixes #
Other notes for review