SendDataColumnSidecarByRoot: Return RODataColumn instead of ROBlob.
#13957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
requested review from
terencechain,
nisdas and
james-prysm
and removed request for
a team
james-prysm
reviewed
May 6, 2024
| @@ -18,7 +18,6 @@ import ( | |||
| "github.com/prysmaticlabs/prysm/v5/consensus-types/interfaces" | |||
| "github.com/prysmaticlabs/prysm/v5/consensus-types/primitives" | |||
| "github.com/prysmaticlabs/prysm/v5/encoding/bytesutil" | |||
| ethpb "github.com/prysmaticlabs/prysm/v5/proto/prysm/v1alpha1" | |||
There was a problem hiding this comment.
oh that's weird we're importing and aliasing twice
nisdas
approved these changes
May 7, 2024
nisdas
pushed a commit
that referenced
this pull request
May 16, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
May 30, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
May 30, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Jun 12, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Jul 17, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Jul 17, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nisdas
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Jul 18, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Jul 29, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nisdas
pushed a commit
that referenced
this pull request
Aug 14, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nisdas
pushed a commit
that referenced
this pull request
Aug 15, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nisdas
pushed a commit
that referenced
this pull request
Aug 20, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Aug 27, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Aug 28, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Aug 28, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Oct 7, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Oct 7, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Oct 8, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Oct 23, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Oct 24, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Nov 20, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Nov 22, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Nov 22, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Nov 25, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Nov 25, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
nalepae
added a commit
that referenced
this pull request
Nov 27, 2024
…ob`. (#13957) * `SendDataColumnSidecarByRoot`: Return `RODataColumn` instead of `ROBlob`. * Make deepsource happier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.