Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra: (partial) spectests #13977

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented May 9, 2024

What type of PR is this?

Other

What does this PR do? Why is it needed?

This PR includes:

  • All buildable spectests
    • Some spectests are not included because the electra functions have not landed in develop yet
  • Re-exports of functions from prior forks (i.e. things that didn't change in electra)

Which issues(s) does this PR fix?

Tracking @ #13849

Other notes for review

I want to introduce this technique of re-exporting methods that haven't changed in the current fork.
When you look at deneb spectests, I found it very strange to see spectests testing
altair.ImportantFunction instead of deneb.ImportantFunction. I was asking myself if this was a
mistake or intentional. With this re-export pattern, electra will export altair.ImportantFunction
and that will be clear to the reader that we are testing electra.ImportantFunction for spec
compliance, but the internals are not changed since altair via the re-export.

Draft until #13976 merges.

Currently missing spectests for electra:

missing tests/minimal/electra/fork_choice/on_block
missing tests/minimal/electra/fork_choice/reorg
missing tests/minimal/electra/fork_choice/withholding
missing tests/minimal/electra/fork_choice/get_proposer_head
missing tests/minimal/electra/fork_choice/get_head
missing tests/minimal/electra/fork_choice/ex_ante
missing tests/minimal/electra/fork_choice/should_override_forkchoice_update
missing tests/minimal/electra/sanity/blocks
missing tests/minimal/electra/sync/optimistic
missing tests/minimal/electra/genesis/validity
missing tests/minimal/electra/genesis/initialization
missing tests/minimal/electra/transition/core
missing tests/minimal/electra/epoch_processing/registry_updates
missing tests/minimal/electra/epoch_processing/effective_balance_updates
missing tests/minimal/electra/epoch_processing/sync_committee_updates
missing tests/minimal/electra/epoch_processing/pending_consolidations
missing tests/minimal/electra/epoch_processing/pending_balance_deposits
missing tests/minimal/electra/operations/execution_layer_withdrawal_request
missing tests/minimal/electra/operations/consolidation
missing tests/minimal/electra/operations/attestation
missing tests/minimal/electra/operations/deposit_receipt
missing tests/minimal/electra/operations/deposit
missing tests/minimal/electra/operations/voluntary_exit
missing tests/minimal/electra/random/random
missing tests/minimal/electra/finality/finality
missing tests/mainnet/electra/fork_choice/on_block
missing tests/mainnet/electra/fork_choice/get_proposer_head
missing tests/mainnet/electra/fork_choice/get_head
missing tests/mainnet/electra/fork_choice/ex_ante
missing tests/mainnet/electra/fork_choice/should_override_forkchoice_update
missing tests/mainnet/electra/sanity/blocks
missing tests/mainnet/electra/sync/optimistic
missing tests/mainnet/electra/transition/core
missing tests/mainnet/electra/epoch_processing/registry_updates
missing tests/mainnet/electra/epoch_processing/effective_balance_updates
missing tests/mainnet/electra/epoch_processing/pending_consolidations
missing tests/mainnet/electra/epoch_processing/pending_balance_deposits
missing tests/mainnet/electra/operations/execution_layer_withdrawal_request
missing tests/mainnet/electra/operations/attestation
missing tests/mainnet/electra/operations/deposit_receipt
missing tests/mainnet/electra/operations/deposit
missing tests/mainnet/electra/operations/voluntary_exit
missing tests/mainnet/electra/random/random
missing tests/mainnet/electra/finality/finality

@prestonvanloon prestonvanloon force-pushed the electra-spectests-skipped branch from 7cc322f to 3425e7a Compare May 9, 2024 21:04
@prestonvanloon prestonvanloon marked this pull request as ready for review May 9, 2024 21:26
@prestonvanloon prestonvanloon requested a review from a team as a code owner May 9, 2024 21:26
@prestonvanloon prestonvanloon marked this pull request as draft May 9, 2024 21:27
@prestonvanloon prestonvanloon force-pushed the electra-spectests-skipped branch from 3425e7a to 2c9af01 Compare May 9, 2024 21:30
@prestonvanloon prestonvanloon marked this pull request as ready for review May 9, 2024 21:33
@prestonvanloon prestonvanloon enabled auto-merge May 9, 2024 21:50
@prestonvanloon prestonvanloon force-pushed the electra-spectests-skipped branch from 2c9af01 to 2f4907a Compare May 10, 2024 12:47
@prestonvanloon prestonvanloon added this pull request to the merge queue May 10, 2024
Merged via the queue into develop with commit 323dd7b May 10, 2024
16 of 17 checks passed
@prestonvanloon prestonvanloon deleted the electra-spectests-skipped branch May 10, 2024 14:16
ErnestK pushed a commit to ErnestK/prysm that referenced this pull request May 19, 2024
* Electra epoch transition, re-exports only

* Buildable electra spectests

Fix minimal tests that are passing on mainnet

* Skip failing tests
nisdas pushed a commit that referenced this pull request Jul 4, 2024
* Electra epoch transition, re-exports only

* Buildable electra spectests

Fix minimal tests that are passing on mainnet

* Skip failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants