Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR includes:
Which issues(s) does this PR fix?
Tracking @ #13849
Other notes for review
I want to introduce this technique of re-exporting methods that haven't changed in the current fork.
When you look at deneb spectests, I found it very strange to see spectests testing
altair.ImportantFunction
instead ofdeneb.ImportantFunction
. I was asking myself if this was amistake or intentional. With this re-export pattern,
electra
will exportaltair.ImportantFunction
and that will be clear to the reader that we are testing
electra.ImportantFunction
for speccompliance, but the internals are not changed since altair via the re-export.
Draft until #13976 merges.Currently missing spectests for electra: