validator/client: process Sync Committee roles separately #13995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
In a DV context, to be compatible with the proposed selection endpoint, the VC must push all partial selections to it instead of just one. Process sync committee role separately within the RolesAt method, so that partial selections can be pushed to the DV client appropriately, if configured.
gsora
force-pushed
the
gsora/fix-RolesAt-dv
branch
from
59ddd60 to
f0f12ec
Compare
|
Force pushed in order to update git username/email, new computer :^) |
prestonvanloon
requested changes
May 14, 2024
|
Weird, I did run the test suite on my machine and it seemed to run just fine? Will double-check and fix all the outstanding issues. |
|
Found a bug in the impl! Fixing as we speak. |
Process sync committee duty at slot boundary as well.
|
@prestonvanloon should be fixed now! |
rkapka
requested changes
May 29, 2024
|
Hey @gsora , thanks a lot for the contribution! A PR got merged in the meantime causing a conflict. Can you please resolve it? The main point of the conflict and my change request is to not return errors from role assignments if possible because that will affect all roles/validators. We should only log an error and continue, if possible. |
…the list ignore the duty and continue
# Conflicts: # validator/client/validator.go
rkapka
requested changes
May 29, 2024
rkapka
previously approved these changes
May 30, 2024
auto-merge was automatically disabled
June 28, 2024 13:00
Head branch was pushed to by a user without write access
rkapka
approved these changes
Jul 1, 2024
prestonvanloon
approved these changes
Jul 1, 2024
|
thank you so much for this PR |
Merged
via the queue into
prysmaticlabs:develop
with commit Jul 1, 2024
657750b
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
In a DV context, to be compatible with the proposed selection endpoint, the VC must push all partial selections to it instead of just one.
Process sync committee role separately within the RolesAt method, so that partial selections can be pushed to the DV client appropriately, if configured.
Which issues(s) does this PR fix?
No issue open for this issue as of now, as it has been detected during internal testing.
Other notes for review