Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Custody Count Correctly #14004

Merged
merged 2 commits into from
May 16, 2024
Merged

Set Custody Count Correctly #14004

merged 2 commits into from
May 16, 2024

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented May 15, 2024

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

We marshal the custody count correctly as an 8-byte slice instead of 1.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added the Ready For Review A pull request ready for code review label May 15, 2024
@nisdas nisdas requested a review from a team as a code owner May 15, 2024 13:58
@nisdas nisdas requested review from kasey, nalepae and rauljordan and removed request for a team May 15, 2024 13:58
prestonvanloon
prestonvanloon reviewed May 15, 2024
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test you could add for this?

edit: nvm i thought this was for develop

saolyn
saolyn reviewed May 15, 2024
View reviewed changes
beacon-chain/sync/sampling_data_columns.go
Comment on lines 63 to 64
// Load the `custody_subnet_count`
// TODO: Do not harcode `custody_subnet_count`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these latest changes, are these comments still relevant?

@nisdas nisdas merged commit a1466d2 into peerDAS May 16, 2024
15 of 16 checks passed
@nisdas nisdas deleted the fixSubnetCustodyENR branch May 16, 2024 07:10
nisdas added a commit that referenced this pull request May 16, 2024
@nisdas
Set Custody Count Correctly (#14004)
55bde50 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request May 30, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
e6239ec 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request May 30, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
812dbc9 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Jun 12, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
1f1dac9 
* Set Custody Count Correctly

* Fix Discovery Count
nisdas added a commit that referenced this pull request Jul 4, 2024
@nisdas
Set Custody Count Correctly (#14004)
326dc5b 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Jul 17, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
5c205f5 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Jul 17, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
c0bd926 
* Set Custody Count Correctly

* Fix Discovery Count
nisdas added a commit that referenced this pull request Jul 18, 2024
@nisdas
Set Custody Count Correctly (#14004)
f3e5e7f 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Jul 18, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
87ac840 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Jul 29, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
a280c6b 
* Set Custody Count Correctly

* Fix Discovery Count
nisdas added a commit that referenced this pull request Aug 14, 2024
@nisdas
Set Custody Count Correctly (#14004)
f2d9c06 
* Set Custody Count Correctly

* Fix Discovery Count
nisdas added a commit that referenced this pull request Aug 15, 2024
@nisdas
Set Custody Count Correctly (#14004)
fecd62b 
* Set Custody Count Correctly

* Fix Discovery Count
nisdas added a commit that referenced this pull request Aug 20, 2024
@nisdas
Set Custody Count Correctly (#14004)
74e2fb4 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Aug 27, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
f2cee36 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Aug 28, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
118a348 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Aug 28, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
1411f89 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Oct 7, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
0ea627d 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Oct 7, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
59e571c 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Oct 8, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
2eff8ac 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Oct 23, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
96efda1 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Oct 24, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
f5acce7 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Nov 20, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
49f71be 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Nov 22, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
9416dbb 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Nov 22, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
fb20129 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Nov 25, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
06275e0 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Nov 25, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
c489c5c 
* Set Custody Count Correctly

* Fix Discovery Count
nalepae pushed a commit that referenced this pull request Nov 27, 2024
@nisdas @nalepae
Set Custody Count Correctly (#14004)
c032e78 
* Set Custody Count Correctly

* Fix Discovery Count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saolyn saolyn saolyn left review comments

@prestonvanloon prestonvanloon prestonvanloon left review comments

@nalepae nalepae nalepae approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nisdas @nalepae @prestonvanloon @saolyn