Refactor assignment container to include proposer slots #14038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
potuz
requested changes
May 22, 2024
| if err != nil { | ||
| return nil, err | ||
| } | ||
| assignmentMap := make(map[primitives.ValidatorIndex]*AssignmentContainer, len(activeValidatorIndices)) |
There was a problem hiding this comment.
Why such a large allocation?
saolyn
reviewed
May 22, 2024
Comment on lines
+196
to
+197
| // If previous proposer indices computation is outside if current proposal epoch range, | ||
| // we need to reset state slot back to start slot so that we can compute the correct committees. |
There was a problem hiding this comment.
Small grammar fixes
Suggested change
| // If previous proposer indices computation is outside if current proposal epoch range, | |
| // we need to reset state slot back to start slot so that we can compute the correct committees. | |
| // If previous proposer indices computation is outside of the current proposal epoch range, | |
| // we need to reset the state slot back to the start slot so that we can compute the correct committees. |
|
Deprecated by #14039 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes. This PR refactors
ProposerSlotsfields toCommitteeAssignmentContainerCommitteeAssignmentsreturn one less argument since proposer slots is already part of the container