Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebFix develop #14040

Merged
merged 5 commits into from
May 23, 2024
Merged

WebFix develop #14040

merged 5 commits into from
May 23, 2024

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented May 22, 2024

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

several validator web and validator api related features broke as part of #13593. this PR fixes them.

  • add some sanity check in e2e

Which issues(s) does this PR fix?

Fixes issues introduced from #13593

Other notes for review

@james-prysm james-prysm added Bug Something isn't working Validator Client labels May 22, 2024
@james-prysm james-prysm requested a review from a team as a code owner May 22, 2024 17:16
@james-prysm james-prysm added API Api related tasks Web UI Related to our beautiful Web UI labels May 22, 2024
@james-prysm james-prysm added this pull request to the merge queue May 23, 2024
Merged via the queue into develop with commit 2e84208 May 23, 2024
17 checks passed
@james-prysm james-prysm deleted the webfix branch May 23, 2024 14:33
prestonvanloon pushed a commit that referenced this pull request May 31, 2024
* fixing issues introduced by PR 13593

* missed setting db

* linting

(cherry picked from commit 2e84208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks Bug Something isn't working Validator Client Web UI Related to our beautiful Web UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants