Only log error when aggregator check fails #14046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
saolyn
reviewed
May 24, 2024
validator/client/validator.go
Outdated
| @@ -705,7 +705,8 @@ func (v *validator) RolesAt(ctx context.Context, slot primitives.Slot) (map[[fie | |||
|
|
|||
| aggregator, err := v.isAggregator(ctx, duty.Committee, slot, bytesutil.ToBytes48(duty.PublicKey), duty.ValidatorIndex) | |||
| if err != nil { | |||
| return nil, errors.Wrap(err, "could not check if a validator is an aggregator") | |||
| aggregator = false | |||
| log.WithError(err).Error("Could not check if a validator is an aggregator") | |||
There was a problem hiding this comment.
Tiny nit since it's checking a specific validator
Suggested change
| log.WithError(err).Error("Could not check if a validator is an aggregator") | |
| log.WithError(err).Error("Could not check if the validator is an aggregator") |
validator/client/validator.go
Outdated
| @@ -730,7 +731,8 @@ func (v *validator) RolesAt(ctx context.Context, slot primitives.Slot) (map[[fie | |||
| if inSyncCommittee { | |||
| aggregator, err := v.isSyncCommitteeAggregator(ctx, slot, bytesutil.ToBytes48(duty.PublicKey), duty.ValidatorIndex) | |||
| if err != nil { | |||
| return nil, errors.Wrap(err, "could not check if a validator is a sync committee aggregator") | |||
| aggregator = false | |||
| log.WithError(err).Error("Could not check if a validator is a sync committee aggregator") | |||
There was a problem hiding this comment.
Same
Suggested change
| log.WithError(err).Error("Could not check if a validator is a sync committee aggregator") | |
| log.WithError(err).Error("Could not check if the validator is a sync committee aggregator") |
prestonvanloon
pushed a commit
that referenced
this pull request
May 31, 2024
* Only log error when aggregator check fails * review (cherry picked from commit 2f2152e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
If for whatever reason we are unable to check if the validator is an aggregator, instead of failing and not assigning any roles we should assume the validator is not an aggregator, log the error and continue. That way the validator will be able to get other rewards for the slot.