Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependent root retrieval for first epoch #14059

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix dependent root retrieval for first epoch #14059

merged 1 commit into from
May 30, 2024

Conversation

terencechain
Copy link
Member

The issue we encountered during the long-running e2e post-summit is as follows:

  • The caller requests duties for epoch 1 at the end of epoch 0
  • In this case, we still use the genesis state even if the requested epoch is 1
  • We should use the genesis root for the dependent root if the requested epoch is 1

@terencechain terencechain requested a review from a team as a code owner May 29, 2024 17:46
saolyn
saolyn reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't appear to be a test case where requestedEpoch > 1

@terencechain
Copy link
Member Author

There doesn't appear to be a test case where requestedEpoch > 1

This shows up in the e2e test

@terencechain terencechain added this pull request to the merge queue May 30, 2024
Merged via the queue into develop with commit 82f0ea5 May 30, 2024
17 checks passed
@terencechain terencechain deleted the fix-dependent-root-retrival-1 branch May 30, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@saolyn saolyn saolyn approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terencechain @saolyn @rkapka