middleware for content type and accept headers #14075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
changed the title
rkapka
reviewed
Jun 4, 2024
api/server/middleware/middleware.go
Outdated
Comment on lines
80
to
93
| accepted := false | ||
| acceptTypes := strings.Split(acceptHeader, ",") | ||
| for _, acceptType := range acceptTypes { | ||
| acceptType = strings.TrimSpace(acceptType) | ||
| for _, serverAcceptedType := range serverAcceptedTypes { | ||
| if strings.HasPrefix(acceptType, serverAcceptedType) { | ||
| accepted = true | ||
| break | ||
| } | ||
| } | ||
| if accepted { | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
We should follow https://datatracker.ietf.org/doc/html/rfc2616#section-14.1. I don't think we have to support all edge cases, but */* and type "/" "*" would be nice to have.
rkapka
requested changes
Jun 4, 2024
| }, | ||
| { | ||
| template: "/eth/v1/beacon/pool/attester_slashings", | ||
| name: namespace + ".SubmitAttesterSlashing", | ||
| handler: server.SubmitAttesterSlashing, | ||
| methods: []string{http.MethodPost}, | ||
| middleware: []mux.MiddlewareFunc{ |
| }, | ||
| { | ||
| template: "/eth/v1/beacon/states/{state_id}/validators", | ||
| name: namespace + ".GetValidators", | ||
| handler: server.GetValidators, | ||
| methods: []string{http.MethodGet, http.MethodPost}, | ||
| middleware: []mux.MiddlewareFunc{ |
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
rkapka
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Adding middleware for handling content type and accept header checks.
Only impacts the beacon apis for now https://ethereum.github.io/beacon-APIs
Which issues(s) does this PR fix?
Fixes #14054
Other notes for review