PeerDAS: Withhold data on purpose. #14076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
requested review from
kasey,
rauljordan and
prestonvanloon
and removed request for
a team
nisdas
reviewed
Jun 4, 2024
| subnet := uint64(colIdx) % params.BeaconConfig().DataColumnSidecarSubnetCount | ||
|
|
||
| if colIdx < dataColumnsWithholdCount { | ||
| log.WithFields(logrus.Fields{ |
There was a problem hiding this comment.
Add which subnet it was supposed to be broadcasted too in the warning log
nisdas
approved these changes
Jun 4, 2024
nalepae
added a commit
that referenced
this pull request
Jun 12, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Jul 17, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Jul 17, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nisdas
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Jul 18, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Jul 29, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nisdas
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nisdas
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nisdas
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Aug 27, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Aug 28, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Aug 28, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Oct 7, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Oct 7, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Oct 8, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Oct 23, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Oct 24, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Nov 20, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Nov 22, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Nov 22, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Nov 25, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Nov 25, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
nalepae
added a commit
that referenced
this pull request
Nov 27, 2024
* Introduce hidden flag `data-columns-withhold-count`. * Address Nishant's comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the hidden
--data-columns-withhold-countflag.When set to a non null
ivalue, the block proposer will withhold all the data columns with index< i.The main purpose of this flag is to test the correctness of the reconstruction either in E2E tests or in interop with Kurtosis.