-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PeerDAS] rework ENR custody_subnet_count and add tests #14077
[PeerDAS] rework ENR custody_subnet_count and add tests #14077
Conversation
17146a9
to
7c6ade9
Compare
beacon-chain/p2p/discovery.go
Outdated
@@ -43,6 +44,11 @@ const ( | |||
udp6 | |||
) | |||
|
|||
const ( | |||
quickProtocolEnrKey = "quic" | |||
custodySubnetCountEnrKey = "custody_subnet_count" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you miss something like:
func (CustodySubnetCount) ENRKey() string { return custodySubnetCountEnrKey }
Thank you for your pull request! The majority of your changes are scheduled for deletion because of ethereum/consensus-specs#3772. If you wish, you can implement this specification change into Prysm, so we'll be able to merge it once the specification PR is merged. (In the contrary, just fix the few comments I made and we'll merge this one.) |
Thanks for the info, I'll update the PR according to the new spec. |
26d3d85
to
33d3e4e
Compare
33d3e4e
to
dfac56f
Compare
@nalepae updated, let me know if it looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run
bazel run //:gazelle -- fix
(CI fails.)
Approved, thanks! |
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
* [PeerDAS] rework ENR custody_subnet_count related code * update according to proposed spec change * Run gazelle
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Rework ENR custody_subnet_count related code
Which issues(s) does this PR fix?
Fixes #
Other notes for review