Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PeerDAS] rework ENR custody_subnet_count and add tests #14077

Merged

Conversation

0x00101010
Copy link

What type of PR is this?
Feature

What does this PR do? Why is it needed?
Rework ENR custody_subnet_count related code

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@0x00101010 0x00101010 force-pushed the peerdas-enr-field-rework-and-test branch from 17146a9 to 7c6ade9 Compare June 3, 2024 22:04
@0x00101010 0x00101010 marked this pull request as ready for review June 3, 2024 22:28
@0x00101010 0x00101010 requested a review from a team as a code owner June 3, 2024 22:28
@0x00101010 0x00101010 requested review from terencechain, nisdas and james-prysm and removed request for a team June 3, 2024 22:28
@0x00101010 0x00101010 changed the title [PeerDAS] rework ENR custody_subnet_count related code [PeerDAS] rework ENR custody_subnet_count and add tests Jun 3, 2024
@@ -43,6 +44,11 @@ const (
udp6
)

const (
quickProtocolEnrKey = "quic"
custodySubnetCountEnrKey = "custody_subnet_count"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you miss something like:

func (CustodySubnetCount) ENRKey() string { return custodySubnetCountEnrKey }

@nalepae
Copy link
Contributor

nalepae commented Jun 4, 2024

Thank you for your pull request!

The majority of your changes are scheduled for deletion because of ethereum/consensus-specs#3772.

If you wish, you can implement this specification change into Prysm, so we'll be able to merge it once the specification PR is merged. (In the contrary, just fix the few comments I made and we'll merge this one.)

@0x00101010
Copy link
Author

Thank you for your pull request!

The majority of your changes are scheduled for deletion because of ethereum/consensus-specs#3772.

If you wish, you can implement this specification change into Prysm, so we'll be able to merge it once the specification PR is merged. (In the contrary, just fix the few comments I made and we'll merge this one.)

Thanks for the info, I'll update the PR according to the new spec.

@0x00101010 0x00101010 force-pushed the peerdas-enr-field-rework-and-test branch from 26d3d85 to 33d3e4e Compare June 4, 2024 16:00
@0x00101010 0x00101010 force-pushed the peerdas-enr-field-rework-and-test branch from 33d3e4e to dfac56f Compare June 4, 2024 16:01
@0x00101010
Copy link
Author

Thank you for your pull request!

The majority of your changes are scheduled for deletion because of ethereum/consensus-specs#3772.

If you wish, you can implement this specification change into Prysm, so we'll be able to merge it once the specification PR is merged. (In the contrary, just fix the few comments I made and we'll merge this one.)

@nalepae updated, let me know if it looks good

@nalepae nalepae added peerDAS Blocked Blocked by research or external factors labels Jun 5, 2024
Copy link
Contributor

@nalepae nalepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run

bazel run //:gazelle -- fix

(CI fails.)

@nalepae
Copy link
Contributor

nalepae commented Jun 5, 2024

Approved, thanks!

@nalepae nalepae removed the Blocked Blocked by research or external factors label Jun 12, 2024
@nalepae nalepae merged commit 0738862 into prysmaticlabs:peerDAS Jun 12, 2024
14 of 16 checks passed
nalepae pushed a commit that referenced this pull request Jun 12, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Jul 17, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Jul 17, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nisdas pushed a commit that referenced this pull request Jul 18, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Jul 18, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Jul 29, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nisdas pushed a commit that referenced this pull request Aug 14, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nisdas pushed a commit that referenced this pull request Aug 15, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nisdas pushed a commit that referenced this pull request Aug 20, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Aug 27, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Aug 28, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Aug 28, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 7, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 7, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 7, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 7, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 8, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 8, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 23, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 23, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 24, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Oct 24, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 20, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 20, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 22, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 22, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 22, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 22, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 25, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 25, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 25, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 25, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 27, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
nalepae pushed a commit that referenced this pull request Nov 27, 2024
* [PeerDAS] rework ENR custody_subnet_count related code

* update according to proposed spec change

* Run gazelle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants