Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerDAS: Store only custodied columns #14083

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

nalepae
Copy link
Contributor

@nalepae nalepae commented Jun 5, 2024

Before this PR:

  1. If a node custody < 50% of the columns, then no reconstruction happens. The node stores only columns it received via gossip.
  2. I a node custody 100% of the columns, and if at least 50% of the columns are received via gossip, then 100% of the columns are reconstructed and 100% of the columns are stored.
  3. If a node custody ]50%; 100%[ of the columns, and if at least 50% of the columns are received via gossip, then 100% of the columns are reconstructed and 100% of the columns are stored.

3. is kind of unexpected since some non custodied columns will be stored.

After this PR:

  1. No change
  2. No change
  3. If a node custody ]50%; 100%[ of the columns, and if at least 50% of the columns are received via gossip, then 100% of the columns are reconstructed and only the custodied columns are stored.

@nalepae nalepae requested a review from a team as a code owner June 5, 2024 15:35
@nalepae nalepae requested review from prestonvanloon, terencechain and nisdas and removed request for a team June 5, 2024 15:35
@nalepae nalepae merged commit 3b62c7b into peerDAS Jun 6, 2024
16 checks passed
@nalepae nalepae deleted the peerDAS-store-only-custodied-columns branch June 6, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants