PeerDAS: Stop generating new P2P private key at start. #14099

nalepae · 2024-06-11T13:51:51Z

https://hackmd.io/@6-HLeMXARN2tdFLKKcqrxw/BJVSxU7VC
Please read commit by commit.

With s = 128 and 4 custody subnets, there is 10,668,000 possible subnets combinations. 128! / (4! * (128 - 4)!)
Regarding the current number of nodes on mainnet (6641, including un-synced ones), each node has a very high probablity to have a unique subnets combination. ==> Subnets combination is enough to identify a given node.

As a result, if a node changes its Node ID (for anonymity) but keeps the same subnets combination, it is very easy to notice that it is actually the same node.

==> Regardless of the computational difficulty to generate a pseudo-deterministic node ID, when peerDAS is activated, we stop rotating the P2P private key at every reboot.

Replace #14098

…nctions.

saolyn · 2024-06-12T00:15:06Z

beacon-chain/p2p/utils.go

@@ -93,7 +95,7 @@ func privKey(cfg *Config) (*ecdsa.PrivateKey, error) {
 		return nil, err
 	}

-	log.Info("Wrote network key to file")
+	log.WithField("file", defaultKeyPath).Info("Wrote network key to")


This log looks a little funny since it isn't really a complete sentence. It looks a bit better like this

Suggested change

log.WithField("file", defaultKeyPath).Info("Wrote network key to")

log.WithField("filepath", defaultKeyPath).Info("Wrote network key to file.")

For comparison:

INFO[0000] Wrote network key to file=path/to/default/key

vs

INFO[0000] Wrote network key to file. filepath=path/to/default/key

My initial intent was to avoid having two times the word file.

Let me propose an alternative!

Fixed in 1d08139.

nisdas

LGTM

* `privKey`: Improve logs. * peerDAS: Move functions in file. Add documentation. * PeerDAS: Remove unused `ComputeExtendedMatrix` and `RecoverMatrix` functions. * PeerDAS: Stop generating new P2P private key at start. * Fix sammy' comment.

nalepae added 4 commits June 10, 2024 14:25

privKey: Improve logs.

55e436e

peerDAS: Move functions in file. Add documentation.

c51bedb

PeerDAS: Remove unused ComputeExtendedMatrix and RecoverMatrix fu…

b616a7f

…nctions.

PeerDAS: Stop generating new P2P private key at start.

303e7c2

nalepae requested a review from a team as a code owner June 11, 2024 13:51

nalepae requested review from rauljordan, saolyn and james-prysm and removed request for a team June 11, 2024 13:51

nalepae mentioned this pull request Jun 11, 2024

PeerDAS: Generate private keys, once derived into node ID, matches the data column subnets already custodied. #14098

Closed

saolyn reviewed Jun 12, 2024

View reviewed changes

nisdas approved these changes Jun 12, 2024

View reviewed changes

Fix sammy' comment.

1d08139

nalepae merged commit e9808cf into peerDAS Jun 12, 2024
14 of 16 checks passed

nalepae deleted the fixPrivateKey branch June 12, 2024 16:05

nalepae restored the fixPrivateKey branch June 12, 2024 22:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PeerDAS: Stop generating new P2P private key at start. #14099

PeerDAS: Stop generating new P2P private key at start. #14099

nalepae commented Jun 11, 2024 •

edited

Loading

saolyn Jun 12, 2024

nalepae Jun 12, 2024

nalepae Jun 12, 2024

nisdas left a comment

	log.WithField("file", defaultKeyPath).Info("Wrote network key to")
	log.WithField("filepath", defaultKeyPath).Info("Wrote network key to file.")

PeerDAS: Stop generating new P2P private key at start. #14099

PeerDAS: Stop generating new P2P private key at start. #14099

Conversation

nalepae commented Jun 11, 2024 • edited Loading

saolyn Jun 12, 2024

Choose a reason for hiding this comment

nalepae Jun 12, 2024

Choose a reason for hiding this comment

nalepae Jun 12, 2024

Choose a reason for hiding this comment

nisdas left a comment

Choose a reason for hiding this comment

nalepae commented Jun 11, 2024 •

edited

Loading