update codegen dep and cleanup organization #14127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
previously approved these changes
Jun 20, 2024
| "includes": attr.label_list(providers = [GoLibrary]), | ||
| "out": attr.output(), |
proto/prysm/v1alpha1/BUILD.bazel
Outdated
| "Withdrawal", | ||
| ], | ||
| exclude_objs = [ | ||
| "Attestation", |
There was a problem hiding this comment.
These excludes look like prior fork objs. Perhaps these can be better arranged like
ssz_gen_marshal(
name = "ssz_generated_altair",
...
objs = ssz_altair_objs,
excludes = ssz_phase0_objs,
)
prestonvanloon
approved these changes
Jun 20, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
Jun 21, 2024
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com> (cherry picked from commit 8cd249c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other - cleanup
What does this PR do? Why is it needed?
Support for cpu detection to branch around vectorized operations is now available directly in gohashtree. This PR removes the hard coded boolean flag to control whether our code uses the vectorized form and relies on gohashtree to internally pick the right approach. This matches what the code currently does, but just removes the generated code that is currently impossible to reach due to the hard-coded boolean config. In preparation for further changes to code generation, this PR also improves the organization of generated code files, grouping them by fork.