Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra: new process_consolidation_request #14163

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Feature

What does this PR do? Why is it needed?

ethereum/consensus-specs#3775

Which issues(s) does this PR fix?

Other notes for review

@prestonvanloon prestonvanloon requested a review from a team as a code owner June 28, 2024 20:20
@@ -548,7 +548,7 @@ func isCompoundingWithdrawalCredential(creds []byte) bool {
// Check if ``validator`` has a 0x01 or 0x02 prefixed withdrawal credential.
// """
// return has_compounding_withdrawal_credential(validator) or has_eth1_withdrawal_credential(validator)
func HasExecutionWithdrawalCredentials(v *ethpb.Validator) bool {
func HasExecutionWithdrawalCredentials(v interfaces.WithWithdrawalCredentials) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@prestonvanloon prestonvanloon added the Electra electra hardfork label Jun 28, 2024
@prestonvanloon prestonvanloon force-pushed the electra-process_consolidation_request branch from 332591d to 275b700 Compare June 29, 2024 22:11
@prestonvanloon prestonvanloon force-pushed the electra-process_consolidation_request branch from 275b700 to 0e7772a Compare July 1, 2024 20:17
@prestonvanloon prestonvanloon enabled auto-merge July 1, 2024 20:17
@prestonvanloon prestonvanloon disabled auto-merge July 1, 2024 20:17
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestonvanloon prestonvanloon added this pull request to the merge queue Jul 2, 2024
Merged via the queue into develop with commit 0aab919 Jul 2, 2024
17 checks passed
@prestonvanloon prestonvanloon deleted the electra-process_consolidation_request branch July 2, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electra electra hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants