Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra: Unskip all spectests #14220

Merged
merged 1 commit into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ import (
)

func TestMainnet_Electra_Transition(t *testing.T) {
t.Skip("TODO: Electra")
fork.RunForkTransitionTest(t, "mainnet")
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ import (
)

func TestMainnet_Electra_Forkchoice(t *testing.T) {
t.Skip("TODO: Electra")
forkchoice.Run(t, "mainnet", version.Electra)
}
1 change: 0 additions & 1 deletion testing/spectest/mainnet/electra/random/random_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ import (
)

func TestMainnet_Electra_Random(t *testing.T) {
t.Skip("TODO: Electra")
sanity.RunBlockProcessingTest(t, "mainnet", "random/random/pyspec_tests")
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ import (
)

func TestMinimal_Electra_Finality(t *testing.T) {
t.Skip("TODO: Electra")
finality.RunFinalityTest(t, "minimal")
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ import (
)

func TestMinimal_Electra_Transition(t *testing.T) {
t.Skip("TODO: Electra")
fork.RunForkTransitionTest(t, "minimal")
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ import (
)

func TestMinimal_Electra_Forkchoice(t *testing.T) {
t.Skip("TODO: Electra")
forkchoice.Run(t, "minimal", version.Electra)
}
1 change: 0 additions & 1 deletion testing/spectest/minimal/electra/random/random_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ import (
)

func TestMinimal_Electra_Random(t *testing.T) {
t.Skip("TODO: Electra")
sanity.RunBlockProcessingTest(t, "minimal", "random/random/pyspec_tests")
}
1 change: 0 additions & 1 deletion testing/spectest/minimal/electra/sanity/blocks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ import (
)

func TestMinimal_Electra_Sanity_Blocks(t *testing.T) {
t.Skip("TODO: Electra")
sanity.RunBlockProcessingTest(t, "minimal", "sanity/blocks/pyspec_tests")
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
// RunUpgradeToElectra is a helper function that runs Electra's fork spec tests.
// It unmarshals a pre- and post-state to check `UpgradeToElectra` comply with spec implementation.
func RunUpgradeToElectra(t *testing.T, config string) {
t.Skip("Failing until spectests are updated to v1.5.0-alpha.3")
require.NoError(t, utils.SetConfig(t, config))

testFolders, testsFolderPath := utils.TestFolders(t, config, "electra", "fork/fork/pyspec_tests")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
)

func RunBlockHeaderTest(t *testing.T, config string) {
t.Skip("Failing until spectests are updated to v1.5.0-alpha.3")
require.NoError(t, utils.SetConfig(t, config))
testFolders, testsFolderPath := utils.TestFolders(t, config, "electra", "operations/block_header/pyspec_tests")
for _, folder := range testFolders {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (
)

func RunExecutionPayloadTest(t *testing.T, config string) {
t.Skip("Failing until spectests are updated to v1.5.0-alpha.3")
require.NoError(t, utils.SetConfig(t, config))
testFolders, testsFolderPath := utils.TestFolders(t, config, "electra", "operations/execution_payload/pyspec_tests")
if len(testFolders) == 0 {
Expand Down
1 change: 0 additions & 1 deletion testing/spectest/shared/electra/operations/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ func RunBlockOperationTest(
body *ethpb.BeaconBlockBodyElectra,
operationFn blockOperation,
) {
t.Skip("Failing until spectests are updated to v1.5.0-alpha.3")
preBeaconStateFile, err := util.BazelFileBytes(path.Join(folderPath, "pre.ssz_snappy"))
require.NoError(t, err)
preBeaconStateSSZ, err := snappy.Decode(nil /* dst */, preBeaconStateFile)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
)

func RunWithdrawalsTest(t *testing.T, config string) {
t.Skip("Failing until spectests are updated to v1.5.0-alpha.3")
require.NoError(t, utils.SetConfig(t, config))
testFolders, testsFolderPath := utils.TestFolders(t, config, "electra", "operations/withdrawals/pyspec_tests")
for _, folder := range testFolders {
Expand Down
Loading