EIP-7549: Attestation packing #14238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Electra
james-prysm
reviewed
Jul 18, 2024
| } | ||
|
|
||
| var attsForInclusion proposerAtts | ||
| if postElectra { |
There was a problem hiding this comment.
if we have the latest state why not do the post electra check from the version there instead of the epoch?
There was a problem hiding this comment.
I noticed postElectra := slots.ToEpoch(blkSlot) >= params.BeaconConfig().ElectraForkEpoch
james-prysm
previously approved these changes
Jul 18, 2024
james-prysm
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Implementation of
compute_on_chain_aggregatefrom https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/validator.md#attestations. This is a naive version that takes the top aggregate for each attestation_data+committee combination.