Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing explicit deadlines on push proposer settings #14285

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Jul 31, 2024

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

PR #14155 broke builder e2e but upon debugging it appears that deadline probably won't be needed in this design with submissions every slot so I removed explicit deadlines on the calls, all deadlines should be inherited or explicit on the HTTP client.

the current issue results in context cancellation while the registrations are being submitted

time="2024-07-31 00:27:31" level=warning msg="failed to register validator on builder" error="could not submit signed registrations to beacon node: failed to perform request for endpoint http://localhost:4375/eth/v1/validator/register_validator: Post "http://localhost:4375/eth/v1/validator/register_validator": context canceled: Builder API validator registration unsuccessful" prefix=client

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@james-prysm james-prysm requested a review from a team as a code owner July 31, 2024 15:21
@james-prysm james-prysm added the Bug Something isn't working label Jul 31, 2024
rkapka
rkapka previously approved these changes Jul 31, 2024
@rkapka rkapka dismissed their stale review July 31, 2024 17:12

post-submit e2e failed

@james-prysm james-prysm enabled auto-merge July 31, 2024 18:02
@james-prysm james-prysm added this pull request to the merge queue Jul 31, 2024
Merged via the queue into develop with commit 0ed74b3 Jul 31, 2024
16 of 17 checks passed
@james-prysm james-prysm deleted the remove-push-proposer-deadlines branch July 31, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants