Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process Electra operations in the right order #14294

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Aug 2, 2024

https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/beacon-chain.md#operations

    ...
    for_ops(body.bls_to_execution_changes, process_bls_to_execution_change)
    for_ops(body.execution_payload.deposit_requests, process_deposit_request)  # [New in Electra:EIP6110]
    # [New in Electra:EIP7002:EIP7251]
    for_ops(body.execution_payload.withdrawal_requests, process_withdrawal_request)
    # [New in Electra:EIP7251]
    for_ops(body.execution_payload.consolidation_requests, process_consolidation_request)

@potuz potuz requested a review from a team as a code owner August 2, 2024 12:32
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the godoc snippet to match the spec too?

@prestonvanloon prestonvanloon added this pull request to the merge queue Aug 2, 2024
Merged via the queue into develop with commit 10f520a Aug 2, 2024
17 checks passed
@prestonvanloon prestonvanloon deleted the electra_operations_order branch August 2, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants