Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine_getPayloadBodiesByRangeV1 - fix, adding hexutil encoding on request parameters #14314

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Aug 7, 2024

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

engine_getPayloadBodiesByRangeV1 parameters should be hex-encoded before call

Which issues(s) does this PR fix?

Fixes #14313

Other notes for review

@james-prysm james-prysm requested a review from a team as a code owner August 7, 2024 14:03
@james-prysm james-prysm changed the title adding hexutil encoding on request parameters engine_getPayloadBodiesByRangeV1 - fix, adding hexutil encoding on request parameters Aug 7, 2024
@james-prysm james-prysm added the Bug Something isn't working label Aug 7, 2024
kasey
kasey previously approved these changes Aug 7, 2024
@james-prysm james-prysm enabled auto-merge August 7, 2024 14:07
@james-prysm james-prysm added this pull request to the merge queue Aug 7, 2024
Merged via the queue into develop with commit 0c0a497 Aug 7, 2024
17 checks passed
@james-prysm james-prysm deleted the bodiesbyrange-fix branch August 7, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

engine_getPayloadBodiesByRangeV1 request encoded as number instead of quantity-string
2 participants