Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugs in PeerDAS Testing #14396

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fix Bugs in PeerDAS Testing #14396

merged 3 commits into from
Aug 29, 2024

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 29, 2024

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Fix Loopvar Bug when looping through our column subscriptions
  • Subscribe to column subnets before hand, so that they do not get blocked in the event we cant find any new peers
  • Parallelize Data Column Computations

Which issues(s) does this PR fix?

N.A

Other notes for review

Acknowledgements

@nisdas nisdas requested a review from a team as a code owner August 29, 2024 05:31
@nisdas nisdas requested review from kasey, rauljordan and saolyn and removed request for a team August 29, 2024 05:31
@nalepae nalepae merged commit 8cd37ab into peerDAS Aug 29, 2024
14 of 16 checks passed
@nalepae nalepae deleted the fixPeerDASBugs branch August 29, 2024 10:43
nalepae added a commit that referenced this pull request Oct 7, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Oct 7, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Oct 7, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Oct 7, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Oct 8, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Oct 23, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Oct 23, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Oct 24, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Nov 20, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Nov 22, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Nov 22, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Nov 25, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Nov 25, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
nalepae added a commit that referenced this pull request Nov 27, 2024
* Fix Various Bugs in PeerDAS

* Remove Log

* Remove useless copy var.

---------

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants