Add Data Column Computation Metrics #14400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
saolyn,
potuz and
james-prysm
and removed request for
a team
nalepae
approved these changes
Aug 30, 2024
nalepae
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
nalepae
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Add Data Column Metrics * Shift it All To Peerdas Package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Metrics Addition
What does this PR do? Why is it needed?
Each time we compute data column sidecars from blobs, we record it for our prometheus metrics so that we are able to track how long and how much they can delay data column propagation.
Which issues(s) does this PR fix?
N.A
Other notes for review